[release/10.0] Fix TableSharingConcurrencyTokenConvention to skip JSON-mapped entities #37286
+56
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip adding shadow concurrency token properties to entities that are mapped to JSON columns. JSON-mapped entities use JSON property names, not column names, and adding a column-mapped property causes model validation to fail. Fixes #37274 Co-authored-by: AndriySvyryd <[email protected]>
Copilot
AI
changed the title
[WIP] Fix issue 37274 in Entity Framework Core
Fix TableSharingConcurrencyTokenConvention to skip JSON-mapped entities
Dec 2, 2025
Copilot finished work on behalf of
AndriySvyryd
December 2, 2025 22:31
Member
|
@copilot Update progress by rewriting the PR summary using this template: |
Contributor
Author
... Updated the PR description with the requested template format. |
AndriySvyryd
changed the title
Copilot
AI
changed the title
[release/10.0] Fix TableSharingConcurrencyTokenConvention to skip JSON-mapped entities
Fix TableSharingConcurrencyTokenConvention to skip JSON-mapped entities
Dec 3, 2025
Copilot finished work on behalf of
AndriySvyryd
December 3, 2025 02:46
AndriySvyryd
changed the title
roji
approved these changes
Dec 3, 2025
SamMonoRT
approved these changes
Dec 4, 2025
Member
|
cc @artl93 |
artl93
approved these changes
Dec 5, 2025
Member
artl93
left a comment
artl93
left a comment
There was a problem hiding this comment.
Regression. Customer reported. No workaround. Approved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37274
Description
The
TableSharingConcurrencyTokenConventionwas incorrectly adding shadow concurrency token properties to JSON-mapped owned entities causing model validation to fail.Customer impact
Apps using TPH inheritance with a concurrency token in the base class and a JSON-mapped owned entity in a derived class get an exception during model building. There is no known workaround other than removing either the concurrency token or the JSON mapping.
How found
Customer reported on EF 10. Not a common scenario.
Regression
Yes, from EF Core 9.x.
Testing
Test added.
Risk
Low. Targeted fix for the affected scenario.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.